Phantasm, Mirror Image and Manta Syle illusion formatting issue

[bu3ny]

Illusions are always spawned using the same pattern:

First illusion: To the east of the unit
Second illusion: To the north of the unit
Third illusion: To the west of the unit
Fourth illusion: To the south of the unit

This goes for every illusion that spawns.

On top of this, Phantasm, Mirror Image and Manta Style also shuffle the units' position. This shuffling, however, has an issue currently. It happens in between the illusion spawns.

This means, depending on when the main hero gets shuffled, some illus spawn based on the caster's original location, while the remaining illus spawn based on the caster's new location. This breaks the formation.

Repro:
1. Just cast a level 3 Phantasm, or Mirror Image and observe the formations.

Result: See spoiler below

Expected: Either the formation should be consistent (always the + formation, or T when it's 3 illus), or simply make the positions completely random within a given radius. Why fix it to cardinal directions anyway?

Spoiler: 

Example: Let's use CK with 4 phantasms as example. 5 units in total get positioned, so there are 5 possible results:

I am assuming that when CK randoms his original position, no further shuffling happens, and if CK is put in one of the other 4 spots, then the last created illusion gets moved to CK's original cast location.

1. CK gets positioned as first, then the 4 illus get positioned based on the new location. In this case, CK is always in the middle, and his illus around him in + formation.


2. An illusion spawns first, using CK's current position, then CK gets positioned, then the remaining three illusions get positioned based on CK's new position. In this case, the formation is like a T-block, with 2 illus trying to take the same spot.


3. Two illusions spawn first, using CK's current position, then CK gets positioned, then the remaining two illusions get positioned based on CK's new position. In this case, the formation is a T-block combined with an L-block.


4. Three illusion spawns first, using CK's current position, then CK gets positioned, then the remaining one illusion gets positioned based on CK's new position. In this case, the formation is an S-block, with 2 illus trying to take the same spot.


5. All four illusions spawns first, using CK's current position, then CK gets positioned. Here we have the default + formation again, with the difference being that CK is now not in the center.