Announcement

Collapse

Forum Rules

  • No flaming or derogatory remarks, directly or through insinuation.
  • No discussion, sharing or referencing illegal software such as hacks, keygen, cracks and pirated software.
  • No offensive contents, including but not limited to, racism, gore or pornography.
  • No excessive spam/meme, i.e. copious one liners in a short period of time, typing with all caps or posting meme responses (text/image).
  • No trolling, including but not limited to, flame incitation, user provocation or false information distribution.
  • No link spamming or signature advertisements for content not specific to Dota 2.
  • No Dota 2 key requests, sell, trade etc.
  • You may not create multiple accounts for any purpose, including ban evasion, unless expressly permitted by a moderator.

  • Please search before posting. One thread per issue. Do not create another thread if there is an existing one already.
  • Before posting anything, make sure you check out all sticky threads (e.g., this). Do not create new threads about closed ones.
  • It is extremely important that you post in correct forum section.

  • Balance discussion only in Misc.
  • All art related (such as hero model) feedbacks go to Art Feedback Forum.
  • All matchmaking feedback should go here: Matchmaking Feedback
  • All report/low priority issues should go here: Commend/Report/Ban Feedback
  • No specific workshop item feedback. These should go to workshop page of that item.
  • When posting in non-bugs section (such as this), use [Bugs], [Discussion] or [Suggestion] prefix in your thread name.



In case you object some action by a moderator, please contact him directly through PM and explain your concerns politely. If you are still unable to resolve the issue, contact an administrator. Do not drag these issues in public.



All rules are meant to augment common sense, please use them when not conflicted with aforementioned policies.
See more
See less

[BUG] Units forcibly removed doesn't correctly delete modifiers.

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • [BUG] Units forcibly removed doesn't correctly delete modifiers.

    Summary:
    Units that is forcebly removed( UTIL_Remove(),RemoveSelf(), 5s after death delete ) and have modifiers on them doesn't correctly remove these modifiers (removed message don't show up when dota_modifier_debug is enabled (server-side only); they does not decrement ref. counter of parent ability.)

    Repro:
    Set convar dota_modifier_debug to 1.
    Create custom spell that uses CreateModifierThinker() with modifier that removes parent in OnIntervalThink() function.

    Result:
    Unit is removed no message from server that buff is removed(which means it skips some stages), ability says that it has 1 modifier referencing it.

    Expected result:
    Modifier is removed by all rules like RemoveModifierByName().

    This bug affects Rubick, i.e use Wild Axes, steal new ability, steal Wild Axes again - now you have 2 Wild Axes entities.


    Few examples of DOTA abilities that show this bug:
    juggernaut_healing_ward: modifier_juggernaut_healing_ward_aura is removed only on client.
    [OnEntityKilled] Classname:npc_dota_base_additive; UnitName:npc_dota_juggernaut_healing_ward; Owner ID:0; Attacker Classname:npc_dota_creep_lane; Attacker ID:-1;
    S [68.70] Removing buff 'modifier_juggernaut_healing_ward_heal' index: 20 to 'npc_dota_hero_rubick'.
    C [68.73] Removing buff 'modifier_juggernaut_healing_ward_heal' index: 20 to 'npc_dota_hero_rubick'.
    C [69.77] Removing buff 'modifier_juggernaut_healing_ward_aura' index: 1 to ''.

    beastmaster_wild_axes: modifier_beastmaster_axe_invulnerable is removed only on client.
    C [171.27] Refreshing buff 'modifier_beastmaster_axe_stack_counter' to 'npc_dota_creep_lane'. - Stack Count: 2
    S [171.27] Removing buff 'modifier_beastmaster_axe_stack_counter' index: 2 to 'npc_dota_creep_lane'.
    C [171.31] Removing buff 'modifier_beastmaster_axe_stack_counter' index: 2 to 'npc_dota_creep_lane'.
    S [172.17] Removing buff 'modifier_beastmaster_wild_axes' index: 25 to 'npc_dota_hero_rubick'.
    C [172.21] Removing buff 'modifier_beastmaster_axe_invulnerable' index: 1 to ''.
    C [172.21] Removing buff 'modifier_beastmaster_axe_invulnerable' index: 1 to ''.
    C [172.21] Removing buff 'modifier_beastmaster_axe_invulnerable' index: 1 to ''.
    C [172.21] Removing buff 'modifier_beastmaster_axe_invulnerable' index: 1 to ''.
    C [172.21] Removing buff 'modifier_beastmaster_wild_axes' index: 25 to 'npc_dota_hero_rubick'.

    rattletrap_rocket_flare: modifier_clockwerk_rocket_flare_thinker is removed only on client.
    C [327.34] Removing buff 'modifier_clockwerk_rocket_flare_thinker' index: 1 to ''.
Working...
X