Announcement

Collapse

Forum Rules

  • No flaming or derogatory remarks, directly or through insinuation.
  • No discussion, sharing or referencing illegal software such as hacks, keygen, cracks and pirated software.
  • No offensive contents, including but not limited to, racism, gore or pornography.
  • No excessive spam/meme, i.e. copious one liners in a short period of time, typing with all caps or posting meme responses (text/image).
  • No trolling, including but not limited to, flame incitation, user provocation or false information distribution.
  • No link spamming or signature advertisements for content not specific to Dota 2.
  • No Dota 2 key requests, sell, trade etc.
  • You may not create multiple accounts for any purpose, including ban evasion, unless expressly permitted by a moderator.

  • Please search before posting. One thread per issue. Do not create another thread if there is an existing one already.
  • Before posting anything, make sure you check out all sticky threads (e.g., this). Do not create new threads about closed ones.
  • It is extremely important that you post in correct forum section.

  • Balance discussion only in Misc.
  • All art related (such as hero model) feedbacks go to Art Feedback Forum.
  • All matchmaking feedback should go here: Matchmaking Feedback
  • All report/low priority issues should go here: Commend/Report/Ban Feedback
  • No specific workshop item feedback. These should go to workshop page of that item.
  • When posting in non-bugs section (such as this), use [Bugs], [Discussion] or [Suggestion] prefix in your thread name.



In case you object some action by a moderator, please contact him directly through PM and explain your concerns politely. If you are still unable to resolve the issue, contact an administrator. Do not drag these issues in public.



All rules are meant to augment common sense, please use them when not conflicted with aforementioned policies.
See more
See less

[Request] Better handling of modifier properties requiring a specific variable type

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • [Request] Better handling of modifier properties requiring a specific variable type

    A couple of days ago, I came to the conclusion through testing that MODIFIER_PROPERTY_BASEDAMAGEOUTGOING_PERCENTAGE had no effect. However, I was informed that it was working correctly for someone else, and through more testing, I discovered that I was setting the value to a FIELD_FLOAT variable when a FIELD_INTEGER one was required.

    Silently ignoring "malformed" values like this isn't the best way of handling them. I know malformed property names will print an error in the console; it would be lovely if the same happened for values (especially since some use floats and some use ints). Alternatively, values could probably be cast to the correct type behind the scenes (though with potential loss of precision when casting from floats to ints).

  • #2
    On a related note, it would also be nice if an error were printed out when a RunScript command is unable to find the desired function.

    Comment


    • #3
      From Beta Notes:

      * Fixed several fields not respecting the %<var_name> format for variables in datadriven items
      * Fixed datadriven abilities not being able to set the proper modifier states

      Maybe fixed these.
      ModDota | My GitHub Profile | My Project's Page

      Comment

      Working...
      X