Announcement

Collapse

Forum Rules

  • No flaming or derogatory remarks, directly or through insinuation.
  • No discussion, sharing or referencing illegal software such as hacks, keygen, cracks and pirated software.
  • No offensive contents, including but not limited to, racism, gore or pornography.
  • No excessive spam/meme, i.e. copious one liners in a short period of time, typing with all caps or posting meme responses (text/image).
  • No trolling, including but not limited to, flame incitation, user provocation or false information distribution.
  • No link spamming or signature advertisements for content not specific to Dota 2.
  • No Dota 2 key requests, sell, trade etc.
  • You may not create multiple accounts for any purpose, including ban evasion, unless expressly permitted by a moderator.

  • Please search before posting. One thread per issue. Do not create another thread if there is an existing one already.
  • Before posting anything, make sure you check out all sticky threads (e.g., this). Do not create new threads about closed ones.
  • It is extremely important that you post in correct forum section.

  • Balance discussion only in Misc.
  • All art related (such as hero model) feedbacks go to Art Feedback Forum.
  • All matchmaking feedback should go here: Matchmaking Feedback
  • All report/low priority issues should go here: Commend/Report/Ban Feedback
  • No specific workshop item feedback. These should go to workshop page of that item.
  • When posting in non-bugs section (such as this), use [Bugs], [Discussion] or [Suggestion] prefix in your thread name.



In case you object some action by a moderator, please contact him directly through PM and explain your concerns politely. If you are still unable to resolve the issue, contact an administrator. Do not drag these issues in public.



All rules are meant to augment common sense, please use them when not conflicted with aforementioned policies.
See more
See less

[Bug] Non-MULTIPLE Item Modifiers and Dropping Items

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

  • [Bug] Non-MULTIPLE Item Modifiers and Dropping Items

    I use the following modifier in one of my item's modifier block:

    Code:
    			"item_battle_fury_rook_modifier_cleave"
    			{
    			
    				"Passive"			"1"
    				"IsHidden"			"0"
    				"IsBuff"			"0"
    				"IsDebuff"			"0"
    				"IsPurgable"		"0"
    				
    				"OnAttackLanded"
    				{
    					"RunScript"
    					{
    						"ScriptFile"					"custom_scripted_abilities.lua"
    						"Function"						"item_battle_fury_rook_on_attack_landed"
    						"CleaveDamagePercentMelee"		"%cleave_damage_percent_melee"
    						"CleaveDamagePercentRanged"		"%cleave_damage_percent_ranged"
    						"CleaveRadius"					"%cleave_radius"
    						"AttackDamage"					"%attack_damage"    //The damage passed in here is before reductions.
    					}
    				}
    			}
    As you can see, it is part of a reimplementation of Battle Fury. Note that this modifier does not have "Attributes" "MODIFIER_ATTRIBUTE_MULTIPLE", so the idea is that regardless of how many Battle Furys the player has, only one "item_battle_fury_rook_modifier_cleave" modifier will be on the player, so the function "item_battle_fury_rook_on_attack_landed" will only be called once every time an attack lands (and not six times if the player has six Battle Furys).

    However, as you can see from the WebM I took at http://a.pomf.se/dfwnkj.webm, when the player has multiple Battle Furys, dropping any one on the ground will result in this modifier being completely removed, even if there are still other Battle Furys in the player's inventory. Picking a Battle Fury back up (or buying a new one) restores the modifier.

    This has to be a bug; the expected behavior is that one "item_battle_fury_rook_modifier_cleave" modifier would remain applied to the hero so long as they have one or more Battle Furys in their inventory.

    Thank you for reading!
Working...
X