Page 2 of 2 FirstFirst 1 2
Results 11 to 20 of 20

Thread: February 14 Bot Update

  1. #11
    Basic Member
    Join Date
    Jan 2014
    Posts
    57
    Quote Originally Posted by ChrisC View Post
    • Fixed a couple more item build bugs for the default bots.
    Thanks Again! and sorry again i found more I'm not sure why I didn't saw them before
    Razors Build is a mess. I found 5 problems till now:

    Code:
    	"item_recipe_force_staff"		"ITEM_EXTENSION" -------->Should Be Added
    	"item_force_staff"		"ITEM_DERIVED"
    	"item_recipe_hurricane_pike"	"ITEM_EXTENSION" -------->Should Be Added
    	"item_hurricane_pike"	"ITEM_DERIVED"
    
    	"item_boots_of_elves"		"ITEM_LUXURY"
    	"item_blade_of_alacrity"	"ITEM_LUXURY"
    	"item_recipe_yasha"		 "ITEM_LUXURY" -------->Should Be Added
    	"item_yasha"			"ITEM_DERIVED"
    
    	"item_belt_of_strength"		"ITEM_LUXURY"
    	"item_ogre_axe"				"ITEM_LUXURY"
    	"item_recipe_sange"		        "ITEM_LUXURY" -------->Should Be Added
    	"item_sange"				"ITEM_DERIVED"
    
    	"item_lifesteal"				"ITEM_LUXURY"
    	"item_reaver"					"ITEM_EXTENSION"
    	"item_mithril_hammer"		"ITEM_EXTENSION" -------->Should Be Added
    	"item_recipe_satanic"			"ITEM_EXTENSION"  ----------------> Should be removed.
    	"item_satanic"					"ITEM_DERIVED"
    And if possible, Please remove warding feature entirely until its fixed. most of the games are now 4vs4 or 4vs5!
    And Finally Bots Don't use Courier any more.
    Last edited by fandogh; 02-15-2017 at 01:11 PM.

  2. #12
    Quote Originally Posted by fandogh View Post
    Thanks Again! and sorry again i found more I'm not sure why I didn't saw them before
    Razors Build is a mess. I found 5 problems till now:

    Code:
    	"item_recipe_force_staff"		"ITEM_EXTENSION" -------->Should Be Added
    	"item_force_staff"		"ITEM_DERIVED"
    	"item_recipe_hurricane_pike"	"ITEM_EXTENSION" -------->Should Be Added
    	"item_hurricane_pike"	"ITEM_DERIVED"
    
    	"item_boots_of_elves"		"ITEM_LUXURY"
    	"item_blade_of_alacrity"	"ITEM_LUXURY"
    	"item_recipe_yasha"		 "ITEM_LUXURY" -------->Should Be Added
    	"item_yasha"			"ITEM_DERIVED"
    
    	"item_belt_of_strength"		"ITEM_LUXURY"
    	"item_ogre_axe"				"ITEM_LUXURY"
    	"item_recipe_sange"		        "ITEM_LUXURY" -------->Should Be Added
    	"item_sange"				"ITEM_DERIVED"
    
    	"item_lifesteal"				"ITEM_LUXURY"
    	"item_reaver"					"ITEM_EXTENSION"
    	"item_mithril_hammer"		"ITEM_EXTENSION" -------->Should Be Added
    	"item_recipe_satanic"			"ITEM_EXTENSION"  ----------------> Should be removed.
    	"item_satanic"					"ITEM_DERIVED"
    And if possible, Please remove warding feature entirely until its fixed. most of the games are now 4vs4 or 4vs5!
    And Finally Bots Don't use Courier any more.
    I've said the bottom sentence so many times lol. Hopefully someone will notice now.

  3. #13
    Valve Developer
    Join Date
    Sep 2011
    Posts
    1,704
    Fixes for the courier issue will be in the next update. We know what the ward issue is, but will probably be the update after that.

  4. #14
    Quote Originally Posted by ChrisC View Post
    Fixes for the courier issue will be in the next update. We know what the ward issue is, but will probably be the update after that.
    Ok, brilliant. Thank you. I'll always keep http://dev.dota2.com/showthread.php?t=277507 updated if there are anymore bugs.
    Last edited by DreadedGhoul575; 02-15-2017 at 05:32 PM.

  5. #15
    Basic Member
    Join Date
    Oct 2016
    Posts
    247
    Quote Originally Posted by fandogh View Post
    Thanks Again! and sorry again i found more I'm not sure why I didn't saw them before
    Razors Build is a mess. I found 5 problems till now:

    Code:
    	"item_recipe_force_staff"		"ITEM_EXTENSION" -------->Should Be Added
    	"item_force_staff"		"ITEM_DERIVED"
    	"item_recipe_hurricane_pike"	"ITEM_EXTENSION" -------->Should Be Added
    	"item_hurricane_pike"	"ITEM_DERIVED"
    
    	"item_boots_of_elves"		"ITEM_LUXURY"
    	"item_blade_of_alacrity"	"ITEM_LUXURY"
    	"item_recipe_yasha"		 "ITEM_LUXURY" -------->Should Be Added
    	"item_yasha"			"ITEM_DERIVED"
    
    	"item_belt_of_strength"		"ITEM_LUXURY"
    	"item_ogre_axe"				"ITEM_LUXURY"
    	"item_recipe_sange"		        "ITEM_LUXURY" -------->Should Be Added
    	"item_sange"				"ITEM_DERIVED"
    
    	"item_lifesteal"				"ITEM_LUXURY"
    	"item_reaver"					"ITEM_EXTENSION"
    	"item_mithril_hammer"		"ITEM_EXTENSION" -------->Should Be Added
    	"item_recipe_satanic"			"ITEM_EXTENSION"  ----------------> Should be removed.
    	"item_satanic"					"ITEM_DERIVED"
    And if possible, Please remove warding feature entirely until its fixed. most of the games are now 4vs4 or 4vs5!
    And Finally Bots Don't use Courier any more.

    the bots have ALWAYS had ruined builds..... but they have always gotten by.
    i used to play with the heroes.txt before we were allowed and they never had the right items in the build to make the items, but the items always got made, even though if i tried to add a bot with the same item config it didnt work. :shrug:

  6. #16
    Basic Member
    Join Date
    Jan 2013
    Posts
    1,547
    Quote Originally Posted by nostrademous View Post
    IsAncient() would be confusing since "THE" Ancient is your base. There currently is a unit-scoped "IsFort()" which is how you check if a unit is THE Ancient, but probably that should be renamed to IsAncient(). IsAncientCreep() is more specific to focus on ancient neutral creeps. Just my 0.02.
    WTF are you guys smoking? How's having two similar named functions like
    Code:
    IsAncient()
    and
    Code:
    IsAncientCreep()
    is not confusing as opposed to the would-be pair of
    Code:
    IsAncient()
    and
    Code:
    IsFort()
    ? Try thinking for more than 5 secs. And BTW, the scripting API has this that way since forever. As far as I can see, so far both APIs had been consistent in naming of same functions until this case, should stay this way, as it makes already familiar with the latter modders learn the bot scripting API easier, win-win for everyone.

  7. #17
    Basic Member
    Join Date
    Mar 2012
    Posts
    2,014
    Well you are certainly the buzzkill. IsAncient() and IsFort() is hundred times more confusing. IsAncient() - in my mnd - will surely be the throne. IsFort() means that a building is fortified.
    The way Chris named them is fine.
    Explanations on the normal, high and very high brackets in replays: here, here & here
    Why maphacks won't work in D2: here

  8. #18
    Basic Member
    Join Date
    Jun 2013
    Posts
    274
    Overall, it doesn't matter to me what functions are called so long as there is documentation explaining what they do. However, my view comes from consistency, or lack thereof, along names on all fronts.

    In game, the structure's are named "Radiant's Ancient" and "Dire's Ancient" respectively.
    The back-end names are "npc_dota_goodguys_fort" and "npc_dota_badguys_fort".

    To Get the Ancient handle you use GetAncient().
    To check if the handle is the Ancient you use IsFort().

    The Ancients have always been referred to as Ancients. It's what the "Ancients" in DOTA refers to. The Ancient creeps came afterwards.
    No one ever refers to the team's Ancients as the team's Forts. When differentiating the creeps from the building, something is always appended to the creeps. Like "Ancient Stack", "Ancient Camp", "Ancient Creep", etc.

    And on the topic of Fort. It's common language in the game to call glyphed structures Fortified. Heck, when I was first looking over the API functions I thought IsFort() was for checking if a building was glyphed/fortified. While many do call for Glyph, the majority of games I play, someone always calls for "Fort" when glyphing is wanted.
    Also, buildings armor type is "Fortified".

    So, it's one big jumbled mess. I think the goal is trying to clean it up at least a little bit. Though, it's bound to continually be present as long as the back-end names don't match the front-end names.

    But, once again, it overall doesn't matter to me. Any name changes will likely affect nothing at this point. In-game naming is often with context, something that's not available on the back-end scripting side. So the 2 will likely never be aligned.
    Last edited by Cornbane; 02-16-2017 at 01:25 PM.

  9. #19
    Valve Developer
    Join Date
    Sep 2011
    Posts
    1,704
    I totally agree that fort-vs-THE ancient-vs-creep that is ancient is suboptimal, but that's what they're named for mostly historical reasons. If there was a super-clean solution that I was happy with I'd change it and make everyone update their scripts, but there isn't, so it's probably just going to stay as-is. Sorry!

  10. #20
    Basic Member
    Join Date
    Jun 2013
    Posts
    274
    Aye. You'll note that all of us gave reasons but ultimately don't care. XD

    It's so minor that it doesn't matter, I just had to chime in because someone implied we were stupid.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •