Results 1 to 3 of 3

Thread: Bloodthorn tooltip is wrong and other inconsistencies among critical strike effects

  1. #1
    Basic Member 2slow4flo's Avatar
    Join Date
    Aug 2016
    Posts
    219

    Bloodthorn tooltip is wrong and other inconsistencies among critical strike effects

    First off all the Bloodthorn tooltip is simply wrong:

    Active ability says:
    All attacks on the silenced target will have True Strike and 100% chance to crit for 140% more damage.
    140% more damage equals 140% additional damage equals 240% total damage.

    Passive ability says:
    Grants a 20% chance for attacks to inflict 175% more damage.
    Same issue, it's not 175% more damage but just "175% damage", see Crystalys.

    In general these tooltips should always say "CRITICAL STRIKE CHANCE // CRITICAL STRIKE DAMAGE" and the description should always be "Grants a x% chance to deal y% damage" where y is the total damage that is dealt (not the additional component).

    Here are critical strike abilities and items with the correct description:
    Update: COUP DE GRACE & Blade Dance have the CHANCE/DAMAGE in the wrong order, CHANCE first then DAMAGE!


    Here are critical strike abilities and items which have minor inconsistencies with the previous descriptions:


    Here are critical strike abilities and items which have major inconsistencies and erroneous descriptions:
    Last edited by 2slow4flo; 11-09-2017 at 02:49 PM.
    The King has arrived.

  2. #2
    Basic Member 2slow4flo's Avatar
    Join Date
    Aug 2016
    Posts
    219
    In general it's up to you if you want the tooltips to say "%CRITICAL DAMAGE" or "%CRITICAL MULTIPLIER". I would prefer multiplier, since it seems less ambiguous.

    I uploaded the changes for dota/resource/dota_english.txt on pastebin: https://pastebin.com/BuPUKe8R

    HTML Code:
    // Bloodthorn fix
    		"DOTA_Tooltip_ability_item_bloodthorn_Description"                      "<h1>Active: Soul Rend</h1> Silences a target for %silence_duration% seconds. At the end of the silence, an additional %silence_damage_percent%%% of all damage taken during the silence will be dealt to the target as magic damage.<br>Range: %tooltip_range%<br><br>All attacks on the silenced target will have True Strike and %tooltip_crit_chance%%% chance to crit for %target_crit_multiplier%%% damage.\n<h1>Passive: Critical Strike</h1> Grants a %crit_chance%%% chance for attacks to inflict %crit_multiplier%%% damage."
    
    
    // Crystalys fix
    		"DOTA_Tooltip_ability_item_lesser_crit_Description"						"<h1>Passive: Critical Strike</h1>Grants each attack a %crit_chance%%% chance to deal %crit_multiplier%%% damage."
    
    
    // Daedalus fix
    		"DOTA_Tooltip_ability_item_greater_crit_Description"					"<h1>Passive: Critical Strike</h1>Grants each attack a %crit_chance%%% chance to deal %crit_multiplier%%% damage."
    
    
    // Boundless Strike fix
    		"DOTA_Tooltip_ability_monkey_king_boundless_strike_strike_crit_mult"	"%CRITICAL DAMAGE:"
    
    
    // Drunken Brawler fix
    		"DOTA_Tooltip_ability_brewmaster_drunken_brawler_crit_chance"				"%CRITICAL CHANCE:"
    		"DOTA_Tooltip_ability_brewmaster_drunken_brawler_crit_multiplier"			"%CRITICAL DAMAGE:"
    
    
    // Walrus Punch fix
    		"DOTA_Tooltip_ability_tusk_walrus_punch_crit_multiplier"		"%CRITICAL DAMAGE:"
    
    
    // Mortal Strike fix
    		"DOTA_Tooltip_ability_skeleton_king_mortal_strike_crit_chance"					"%CRITICAL CHANCE:"
    
    
    // Alpha Wolf: Critical Strike fix
    		"DOTA_Tooltip_ability_alpha_wolf_critical_strike_crit_chance"						"%CRITICAL CHANCE:"
    
    
    // Blade Dance and Coup De Grace have the wrong order, tooltip should display CHANCE first then DAMAGE
    // Swapping the lines does not change the order in the tooltip however.
    Last edited by 2slow4flo; 11-29-2017 at 12:08 AM.
    The King has arrived.

  3. #3
    fixed

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •